On Wed, 20 May 2026 23:25:57 GMT, Shawn Emery <[email protected]> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> second round of review from Sandhya
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 1156:
>
>> 1154:
>> 1155: void StubGenerator::generate_sha3_stubs() {
>> 1156: bool avx512Available = VM_Version::supports_evex() &&
>> VM_Version::supports_avx512bw();
>
> Shouldn't the check also be against `avx512vl` given that the 128 and 256 bit
> vector lengths are utilized in this update? In addition, a `avx512dq` check
> should also be included given that `evinserti64x2` is used. If so then a
> better check would be for `supports_avx512vlbwdq()`.
Good point. I think I got rid of DQ requirement.. so `supports_avx512vlbw()`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31125#discussion_r3277817598
