On Thu, 21 May 2026 08:23:44 GMT, Aleksey Shipilev <[email protected]> wrote:
>> Why the rabbit hole? `stubAddr` is the local here, it is not guaranteed to
>> be `nullptr`, unless we compile with extra hardening:
>>
>>
>> bool LibraryCallKit::inline_keccak(vmIntrinsics::ID id) {
>> address stubAddr;
>
> Also, I think `assert(false, "dont call");` need to be `ShouldNotReachHere()`.
> "Why the rabbit hole?.. "
Oh.. I misunderstood the question somewhat.. I thought you were asking if the
stubs would get a default value on the platform without support. added
initialization to nullptr and changed default case as recommended, thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31125#discussion_r3285416654
