On Thu, 28 May 2026 19:47:25 GMT, Weijun Wang <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> since updates
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 176:
>
>> 174: * @return the default {@code PEMDecoder}
>> 175: *
>> 176: * @since 25
>
> You can remove the `@since` above since it can be inherited from the class.
It's possible I added too many, but I was responding to failures by
`JavaBaseCheckSince`.
> src/java.base/share/classes/java/security/PEMDecoder.java line 335:
>
>> 333: * @throws EOFException if no PEM data is found or the stream ends
>> unexpectedly
>> 334: * @throws IllegalArgumentException if decoding fails
>> 335: * @throws NullPointerException when {@code InputStream} is {@code
>> null}
>
> Other methods use `if ... is null`.
This was in response to your comment about not liking "if `is` is null", so I
reworded it
> src/java.base/share/classes/java/security/PEMDecoder.java line 379:
>
>> 377: * @throws IllegalArgumentException on error in decoding or no PEM
>> data found
>> 378: * @throws ClassCastException if {@code tClass} does not represent
>> the PEM type
>> 379: * @throws NullPointerException when any input values are {@code
>> null}
>
> Other methods use `if ... is null`.
I changed "when" to "if", but it matches the other `decode(is, class)`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3320816620
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3320830230
PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3320990136
