On Mon, 1 Jun 2026 20:42:37 GMT, Anthony Scarpino <[email protected]> wrote:
>> Please review the third preview of the PEM API at >> https://openjdk.org/jeps/8376991. The most significant changes from the >> second preview, JEP 524 (https://openjdk.org/jeps/524), include: >> >> - The `PEM` class is now an ordinary class rather than a record. It adds >> Binary-encoded content constructors and data is defensively copied. >> - The `DEREncodable` interface is renamed to `BinaryEncodable` to more >> accurately reflect the binary data stored in PEM text. >> - In `EncryptedPrivateKeyInfo`, the `encrypt` methods now accept >> `BinaryEncodable`, and the `getKey()` and `getKeyPair()` methods no longer >> include a `Provider` parameter. >> - A new `CryptoException` class indicates failures in cryptographic >> processing at runtime. >> >> thanks >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Anthony Scarpino has updated the pull request incrementally with one > additional commit since the last revision: > > review comments src/java.base/share/classes/java/security/PEM.java line 212: > 210: * > 211: * @return a newly-allocated byte array containing the decoded > content > 212: * @throws IllegalArgumentException if decoding fails The decode method has no arguments so it's a bit strange to throw IllegalArgumentException. Has this been discussed already? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29640#discussion_r3348011325
