On Tue, 17 Mar 2026 20:51:04 GMT, Anthony Scarpino <[email protected]> wrote:
> Hi, > > Please review this change that prevents multiple KeyUpdate messages from > being sent when the KeyLimit defined in the java.security file has been > reached. > > https://bugs.openjdk.org/browse/JDK-8329548 > > thanks > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Just a couple nits so far. I wouldn't mind seeing some extra commenting in the worker portions of the client and server tests. It would help if we need to maintain it in the future. Marked as reviewed by jnimeh (Reviewer). src/java.base/share/classes/sun/security/ssl/SSLCipher.java line 621: > 619: /** > 620: * Check if processed bytes have reached the key usage limit. > 621: * If key usage limit is not be monitored, return false. Nit: "limit" -> "limits", "is not be" -> "are not" src/java.base/share/classes/sun/security/ssl/SSLCipher.java line 632: > 630: if (keyLimitEnabled == false) { > 631: if (SSLLogger.isOn()) { > 632: SSLLogger.fine("KeyUpdate already send, skipping"); typo: send -> sent test/jdk/sun/security/ssl/SSLEngineImpl/KeyUpdateOnce.java line 127: > 125: List<String> list = > output.stderrShouldContain("Thread-0") > 126: .asLines().stream() > 127: .filter(s -> s.contains("KeyUpdate already send, > skipping")) nit: "send" -> "sent" ------------- PR Review: https://git.openjdk.org/jdk/pull/30288#pullrequestreview-4000805328 PR Review: https://git.openjdk.org/jdk/pull/30288#pullrequestreview-4412871996 PR Review Comment: https://git.openjdk.org/jdk/pull/30288#discussion_r2983029955 PR Review Comment: https://git.openjdk.org/jdk/pull/30288#discussion_r2983016513 PR Review Comment: https://git.openjdk.org/jdk/pull/30288#discussion_r2983084766
