On Tue, 17 Mar 2026 20:51:04 GMT, Anthony Scarpino <[email protected]> wrote:
> Hi, > > Please review this change that prevents multiple KeyUpdate messages from > being sent when the KeyLimit defined in the java.security file has been > reached. > > https://bugs.openjdk.org/browse/JDK-8329548 > > thanks > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Was there a reason for only adjusting this in the read cipher? `SSLWriteCipher` appears to have the same issue: ~~~ public boolean atKeyLimit() { if (keyLimitCountdown >= 0) { return false; } // Turn off limit checking as KeyUpdate will be occurring keyLimitEnabled = false; return true; } ~~~ As with the read cipher before this patch, if `keyLimitCountdown` drops below zero, `keyLimitEnabled` will be set to `false`. But this has no effect on subsequent calls to this method which will again set the variable to `false` and return `true` to say the limit has been reached, even though the check should have been disabled by the first call. ------------- PR Comment: https://git.openjdk.org/jdk/pull/30288#issuecomment-6611614986
