On Fri, 5 Jun 2026 21:27:20 GMT, Chen Liang <[email protected]> wrote:
>> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java >> line 319: >> >>> 317: .withInterfaceSymbols(interfaces); >>> 318: // All Classes in the BSM argument method types are >>> loaded; no need for LoadableDescriptors >>> 319: >> >> We were generating preview classes at one point, but now that there's "no >> need for LoadableDescriptors", I think we can revert changes to this file >> completely? > > We can indeed drop this safely. Do you think this comment should be dropped > as well? If so, I can drop the comment in `ProxyGenerator` too. It's actually a useful comment, and relevant even when we're out of preview. So I don't mind keeping it. But I would undo the code change, there's no need to be generating preview classes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3365657585
