On Mon, 8 Jun 2026 07:28:47 GMT, Alan Bateman <[email protected]> wrote:
>> David Simms has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 2754 commits: >> >> - Merge remote-tracking branch 'valhalla/lworld' into >> jep401_sub_review_8317279 >> - Merge >> >> Merge jdk-27+24 >> - 8385674: [lworld] TestNullableInlineTypes.java fails after JDK-8325632 >> >> Reviewed-by: mchevalier >> - 8385652: [lworld] RedefineClasses should use stack map frame name >> >> Reviewed-by: fparain >> - 8384107: [lworld] Update runtime/contended tests to run the same testing >> for value classes >> >> Reviewed-by: fparain, lmesnik >> - 8385600: [lworld] DA/DU issues with strict fields >> >> Reviewed-by: vromero >> - 8384897: [lworld] this.staticField should be restricted in early >> construction context >> >> Reviewed-by: liach, vromero >> - 8385601: [lworld] Update testing documentation for the ValueClassPlugin >> jtreg option >> >> Reviewed-by: lmesnik >> - 8385569: [lworld] Apply JDK-8343767 to Valhalla specific StubRoutines >> >> Reviewed-by: fparain, vlivanov >> - 8385581: [lworld] Remove the experimental JVMCI feature >> 8382708: [lworld] JVMCI support for Value Objects >> 8372605: [lworld] >> compiler/jvmci/jdk.vm.ci.runtime.test/src/jdk/vm/ci/runtime/test/TestResolvedJava*.java >> fail with --enable-preview >> >> Reviewed-by: thartmann >> - ... and 2744 more: https://git.openjdk.org/jdk/compare/2c7efc08...9e804255 > > test/lib/jdk/test/lib/helpers/StrictProcessor.java line 234: > >> 232: if (cle instanceof InnerClassesAttribute ica) { >> 233: // VM needs identity bit fixed >> 234: var fixedInfos = ica.classes().stream().map(info -> >> InnerClassInfo.of(info.innerClass(), info.outerClass(), info.innerName(), >> info.flagsMask() | ACC_IDENTITY)).toList(); > > @liach There are >20 uses of var in this class processor and the type is not > obvious to a human reader in many cases. It would help if the use of "var" > could be dialed down a bit so that human reader have some chance to guess the > types. Stuart wrote a useful set of guidelines on this. > > (StrictProcessor is very useful of course, it's just reading the code isn't > as easy as it should) I have rollbacked almost all uses of `var` except the `var classTransform = ClassTransform.xxx` one. Also I noticed the `--deferSuperCall` ability is actually unnecessary for this processor and have since removed it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3380617985
