On Tue, 9 Jun 2026 22:10:02 GMT, Artur Barashev <[email protected]> wrote:

>> SunJSSE implementation of `SSLEngine` throws an IllegalStateException if 
>> being used to start a handshake or wrap/unwrap bytes before calling 
>> `setUseClientMode()`. Research shows that it's not necessarily needed and 
>> the `server` default can be used. We do recommend users to set the desired 
>> mode explicitly in `SSLContext` and `SSLContextSpi` javadocs.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Artur Barashev has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Update test description

test/jdk/sun/security/ssl/SSLEngineImpl/EngineEnforceUseClientMode.java line 1:

> 1: /*

It seems like it would also be useful to have a test where you don't call 
setUseClientMode so that the default works correctly. Also, maybe change the 
name of the test to something like EngineTestClientMode?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31422#discussion_r3390062806

Reply via email to