On Wed, 24 Jun 2026 13:52:04 GMT, Alan Bateman <[email protected]> wrote:

>> src/java.base/share/classes/jdk/internal/module/ModulePath.java line 155:
>> 
>>> 153:     /**
>>> 154:      * Returns a ModuleFinder that locates modules in a JDK exploded 
>>> image.
>>> 155:      * @param modulesDir the modules directory ($JAVA_HOME/modules)
>> 
>> Is this is a typo? Should it have been `$JAVA_HOME/jmods`?
>
> This factory method is for the JDK exploded images, so $JAVA_HOME/modules is 
> correct.
> 
> (The $JAVA_HOME/jmods directory is used for packaged modules, typically 
> `jlink` is run with ` --keep-packaged-modules` to save the packaged modules 
> in that location).

I hadn't paid attention that for exploded images the modules directory is named 
"modules". I just got confused when I saw that name, because in my mind 
`modules` meant the runtime image (regular file) that resides in 
`$JAVA_HOME/lib` directory. 

Thank you for clarifying.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31123#discussion_r3468371453

Reply via email to