On Tue, 30 Jun 2026 18:12:27 GMT, Artur Barashev <[email protected]> wrote:

>> Andreas Chmielewski has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review comments
>
> test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java line 
> 212:
> 
>> 210:     }
>> 211: 
>> 212:     private static class SSLServer extends SSLContextTemplate 
>> implements Runnable, AutoCloseable {
> 
> Did you consider `BulkCipherDisabledAlgorithms` extending `SSLSocketTemplate` 
> instead of implementing  Server/Client functionality yourself? That would 
> simplify the test considerably.

Thx! I did not consider this helper class.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3501097151

Reply via email to