On Tue, 30 Jun 2026 19:11:16 GMT, Artur Barashev <[email protected]> wrote:
>> Andreas Chmielewski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review: Use SSLSocketTemplate
>
> test/jdk/javax/net/ssl/ciphersuites/BulkCipherDisabledAlgorithms.java line
> 219:
>
>> 217:
>> 218: @Override
>> 219: protected void runClientApplication(SSLSocket socket) throws
>> Exception {
>
> Any particular reason you override `runClientApplication` and
> `runServerApplication`? Looks redundant, the handshake will be performed by
> default anyhow.
Good point. My initial intent was to keep the test minimal and explicitly
trigger only the handshake (and not more), but in this case I agree — this
reduces the lines of code within the test and simplifies it without changing
behavior. I’m fine with dropping them.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31633#discussion_r3501549903
