On Tue, 11 Aug 2026 16:51:41 GMT, Shawn Emery <[email protected]> wrote:

>> Daniel Skantz has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   param order
>
> src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 358:
> 
>> 356: //          xmm17: q
>> 357: // Output:  xmm0-xmm7 (reduced coefficients each in [0, q])
>> 358: // Scratch: xmm8-xmm15
> 
> I would order `Output` last, as this would adhere to other method comments.
> 
> The rest looks good.  Thank you for the refresh.

Thanks. Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32295#discussion_r3764232395

Reply via email to