On Tue, 11 Aug 2026 07:24:35 GMT, Daniel Skantz <[email protected]> wrote:
> Small fixups: spacing issues, typing errors, clarify return value divergence > at their sites. Tidy up barrettReduce block comment. Testing: build / GHA > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 357: > 355: // xmm16: Barrett multiplier > 356: // xmm17: q > 357: // Output: xmm0-xmm7 (reduced coefficients each in [0, q]) Since you're describing set notation, this would be: > // Output: xmm0-xmm7 (reduced coefficients each in [0, q)) Note the exclusion of `q`. src/hotspot/cpu/x86/stubGenerator_x86_64_kyber.cpp line 358: > 356: // xmm17: q > 357: // Output: xmm0-xmm7 (reduced coefficients each in [0, q]) > 358: // Scratch: xmm8-xmm15 I would order `Output` last, as this would adhere to other method comments. The rest looks good. Thank you for the refresh. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32295#discussion_r3759968398 PR Review Comment: https://git.openjdk.org/jdk/pull/32295#discussion_r3759968735
