On Fri, 7 Aug 2026 01:32:00 GMT, Hai-May Chao <[email protected]> wrote:

>> Andreas Chmielewski has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review
>
> src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/SunPKCS11.java line 
> 1463:
> 
>> 1461:                     return new P11TlsMasterSecretGenerator(
>> 1462:                         token, algorithm, mechanism);
>> 1463:                 } else if (algorithm == 
>> "SunTls12ExtendedMasterSecret") {
> 
> It looks like a name mismatch here. Registration uses 
> `SunTlsExtendedMasterSecret` at #1035, and instantiation uses 
> `SunTls12ExtendedMasterSecret`.

thx! During final cleanup I have introduced this bug

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3794437315

Reply via email to