On Tue, 25 Aug 2026 14:05:32 GMT, Andreas Chmielewski 
<[email protected]> wrote:

>> I want to propose this enhancement. Please see the CSR.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Andreas Chmielewski has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Review comments

src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/P11TlsExtendedMasterSecretGenerator.java
 line 84:

> 82: 
> 83:         int tlsVersion = (spec.getMajorVersion() << 8) | 
> spec.getMinorVersion();
> 84:         if (tlsVersion != 0x0303) {

Hmm, the same-named impl from SunJCE provider supports older TlsVersion. Also 
RFC7627 does not limit this to TLS 1.2 only. Since this is used by JSSE 
implementations, maybe you should not put extra limitation here?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32081#discussion_r3916886636

Reply via email to