On Sat, 15 Aug 2026 00:53:41 GMT, Shawn Emery <[email protected]> wrote:
>> https://bugs.openjdk.org/browse/JDK-8381223 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > src/java.base/share/classes/sun/security/provider/ML_DSA.java line 1454: > >> 1452: // coeffs1 is in the ordinary NTT domain and coeffs2 is in >> the >> 1453: // Montgomery NTT domain. Their ordinary product is >> therefore in >> 1454: // the Montgomery domain; no conversion of coeffs2 is >> necessary. > > With your update this comment is no longer valid ;). Both inputs and product > are in the ordinary NTT domain. Suggestion: >> // Both input coefficients are in the ordinary NTT domain, >> therefore >> // the product is in the same domain. fixed ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/32259#discussion_r3798454476
