On Mon, 17 Aug 2026 20:15:52 GMT, Mark Powers <[email protected]> wrote:
>> https://bugs.openjdk.org/browse/JDK-8381223 >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > comment from Shawn Looks good. Some tiny comments. src/java.base/share/classes/sun/security/provider/ML_DSA.java line 1627: > 1625: // Reduces a product of two NTT coefficients modulo ML_DSA_Q to its > 1626: // canonical representative. The product is bounded by ML_DSA_Q > squared. > 1627: private static int barrettReduce(long value) { Can we rename the argument to `product`? This makes the comment clearer. ------------- PR Review: https://git.openjdk.org/jdk/pull/32259#pullrequestreview-4976856681 PR Review Comment: https://git.openjdk.org/jdk/pull/32259#discussion_r3816804116
