Re: RFR: 8391472: ML-DSA and ML-KEM default parameter sets for keytool

[Mark Powers]

On Tue, 1 Sep 2026 01:05:29 GMT, Weijun Wang <wei...@openjdk.org> wrote:

> Add ML-DSA and ML-KEM default parameter sets for `keytool -genkeypair`.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The rest looks good to me.

src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java line 
154:

> 152:             try {
> 153:                 
> keyGen.initialize(keyType.toUpperCase(Locale.ROOT).equals("EC")
> 154:                         ? new ECGenParameterSpec(name)

`ECGenParameterSpec` is also used in the catch below, so it seems the code is 
duplicated.

-------------

Marked as reviewed by mpowers (Committer).

PR Review: https://git.openjdk.org/jdk/pull/32616#pullrequestreview-5091932797
PR Review Comment: https://git.openjdk.org/jdk/pull/32616#discussion_r3916002391