Re: RFR: 8391472: ML-DSA and ML-KEM default parameter sets for keytool

[Weijun Wang]

On Wed, 2 Sep 2026 13:37:44 GMT, Matthew Donovan <mdono...@openjdk.org> wrote:

>> Add ML-DSA and ML-KEM default parameter sets for `keytool -genkeypair`.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> test/jdk/sun/security/tools/keytool/DefaultGroupName.java line 62:
> 
>> 60:     private static final char[] PASS = "changeit".toCharArray();
>> 61: 
>> 62:     private static String last = "";
> 
> this variable name is pretty vague with respect to what it does/how it's 
> used. Maybe change it to something like `providerAlg` and/or add a comment 
> that says the custom provider will set it.

I change to

    // A public observable status string set inside our private
    // provider so we can check what has been done recently.
    private static String status = "";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32616#discussion_r3974206026