Re: RFR: 8381641: ML-DSA in TLS 1.3 [v6]

[Artur Barashev]

On Wed, 16 Sep 2026 08:20:32 GMT, Hai-May Chao <hc...@openjdk.org> wrote:

>> This is to add support in SunJSSE for the TLS 1.3 ML-DSA signature schemes: 
>> mldsa44, mldsa65, and mldsa87.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hai-May Chao has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Tests update with Artur's comments
>  - Revert change to TLSCurveMismatch.java
>  - Revert change to CertificateMessage.java

test/jdk/sun/security/ssl/SignatureScheme/MLDSAClientAuthMismatch.java line 67:

> 65: 
> 66:     private static final String TEST_CASE = 
> System.getProperty("test.case");
> 67: 

Suggestion:

    private MLDSAClientAuthMismatch() {
        super(true); // server on separate thread, client on current thread
    }

test/jdk/sun/security/ssl/SignatureScheme/MLDSAClientAuthMismatch.java line 141:

> 139:             }
> 140: 
> 141:             assertEquals(e.getMessage(), "(internal_error) Received " +

Check the client’s underlying error:

Suggestion:

            assertEquals(e.getMessage(), "(internal_error) No supported "
                    + "CertificateVerify signature algorithm for ML-DSA key");

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4027366963
PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4027384982