On Wed, 16 Sep 2026 08:20:32 GMT, Hai-May Chao <[email protected]> wrote:

>> This is to add support in SunJSSE for the TLS 1.3 ML-DSA signature schemes: 
>> mldsa44, mldsa65, and mldsa87.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hai-May Chao has updated the pull request incrementally with three additional 
> commits since the last revision:
> 
>  - Tests update with Artur's comments
>  - Revert change to TLSCurveMismatch.java
>  - Revert change to CertificateMessage.java

test/jdk/sun/security/ssl/SignatureScheme/MLDSANotAllowedInTLS12.java line 37:

> 35: import java.util.List;
> 36: 
> 37: public class MLDSANotAllowedInTLS12 extends AbstractCheckSignatureSchemes 
> {

I would be useful to also have a positive test for TLSv1.3. Such test can be 
extended from this class: we'll override `getProtocol()` and use 
`assertMldsa()` instead of `assertNoMldsa()`; `checkCertificateRequest()` can 
be overriden with an empty method since CertificateRequest message is encrypted 
in TLSv1.3.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32529#discussion_r4027812342

Reply via email to