On Wed, 9 Sep 2026 17:04:23 GMT, Artur Barashev <[email protected]> wrote:

>> Main changes:
>> - Adding `(SSLEngine | SSLSocket | 
>> SSLServerSocket).getSupportedNamedGroups()` public API methods.
>> - Adding `ExtendedSSLSession.getNamedGroup()` public API method.
>> 
>> Additional side-issues being addressed:
>> - Repurpose currently unused NamedGroup.namesOf() method
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Artur Barashev has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains 11 commits:
> 
>  - Merge branch 'master' into JDK-8388519
>    
>    # Conflicts:
>    #  src/java.base/share/classes/sun/security/ssl/Finished.java
>  - Address review comments. Update ImmutableExtendedSSLSession.
>  - TLSv1.2 uses ephemeral elliptic-curve key exchange by default
>  - Repurpose unused NamedGroup.namesOf() method
>  - Minor test changes
>  - Test improvements
>  - More unit tests
>  - Add SSLSocket unit test
>  - Restore recordEvent signature
>  - Code re-arrangement
>  - ... and 1 more: https://git.openjdk.org/jdk/compare/39f3ef1b...d4add784

src/java.base/share/classes/javax/net/ssl/SSLSocket.java line 886:

> 884:      * Specification, and may also include other named groups that the 
> provider
> 885:      * supports.
> 886:      *

Suggest adding an API Note (and an `@see` label) telling users how to get the 
list of enabled named groups, ex: "To get the names of the named groups which 
are currently enabled for use on this connection, call 
`getSSLParameters().getNamedGroups()`"

Same comment for `SSLEngine` and `SSLServerSocket`.

src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 34:

> 32: import java.security.spec.NamedParameterSpec;
> 33: import java.util.Arrays;
> 34: import java.util.Collections;

Can remove this import now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4169035504
PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4009090516

Reply via email to