On Mon, 5 Oct 2026 19:08:50 GMT, Sean Mullan <[email protected]> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update javadocs
>
> src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 437:
>
>> 435:
>> 436: static String[] namesOf(List<NamedGroup> groups) {
>> 437: return groups.stream().map(ng ->
>> ng.name).toArray(String[]::new);
>
> Can `groups` or `ng` ever be `null` as in the prior code?
No, they can't. Currently the input for this method is always the output of the
`NamedGroup.SupportedGroups.getSupportedGroups` below.
> src/java.base/share/classes/sun/security/ssl/NamedGroup.java line 437:
>
>> 435:
>> 436: static String[] namesOf(List<NamedGroup> groups) {
>> 437: return groups.stream().map(ng ->
>> ng.name).toArray(String[]::new);
>
> Did you consider the prior log message unnecessary or too noisy for some
> reason?
You mean `ng.isAvailable` check in the previous version of the method? We don't
do that here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4188168636
PR Review Comment: https://git.openjdk.org/jdk/pull/32560#discussion_r4188186444
