On Tue, 13 Oct 2026 02:32:09 GMT, Shawn Emery <[email protected]> wrote:

> implKyberAddPolyJava() returns the sum of two polynomials in the first 
> operand and not the result argument. Currently callers use the same variable 
> for the result and the first operand, so this change set corrects this issue 
> as a matter of future-proofing.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

This is correct.

(But now I am very confused how my Intrinsic Fuzz test, which uses this 
function as a reference is correct! Strange.. need to question my results now.. 
https://github.com/vpaprotsk/jdk/pull/11/changes#diff-b2aa8ceb12011c3e2e3470c2d63b94f9a277ea204589171e8b1715e146dc9e11R269-R273
 )

-------------

Marked as reviewed by vpaprotski (Committer).

PR Review: https://git.openjdk.org/jdk/pull/33331#pullrequestreview-5498814780

Reply via email to