On Mon, 26 Oct 2026 19:41:46 GMT, Artur Barashev <[email protected]> wrote:
>> Roland Mesde has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Copyright Year and Add Comment Explaining Family Depth > > src/java.base/share/classes/sun/security/ssl/SSLSessionContextImpl.java line > 2: > >> 1: /* >> 2: * Copyright (c) 1999, 2025, Oracle and/or its affiliates. All rights >> reserved. > > Copyright year should be updated. Done. > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 120: > >> 118: private final AtomicLong familyDepthLimit; >> 119: private final long familyDepth; >> 120: private boolean hasDescendant; > > Let's add a comment above these variables explaining why we need them. I > would also mention that invalidation crosses sibling subtrees, i.e > `familyDepthLimit` is shared across all of them. Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4389768067 PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4389770158
