On Tue, 27 Oct 2026 19:08:37 GMT, Artur Barashev <[email protected]> wrote:
>> Roland Mesde has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update Copyright Header > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 121: > >> 119: /* >> 120: * A family is composed of a root session and the sessions that are >> 121: * derived from its ticket. Sessions that are derived from the >> tickets of > > Nit: I think we should define membership through the copy constructor to > avoid ambiguity. A server reconstructing a stateless ticket starts a new > family with depth 0. Agreed and that is how it currently works. Only the copy constructor SSLSessionImpl(SSLSessionImpl, SessionId) joins an existing family. Every other constructor starts a new family at familyDepth 0. > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 126: > >> 124: * is greater than or equal to the familyDepthLimit, which is >> initially set >> 125: * to Long.MAX_VALUE. Once a session is invalidated at the >> specified depth, >> 126: * all deeper sessions will be invalidated, not just its branch >> descendants. > > Let's clarify that invalidating all deeper sessions happens only when > `hasDescendant` is `true`. Invalidating a session that has never produced a > copy leaves the shared limit unchanged. Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4401601504 PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4401593642
