On Fri, 30 Oct 2026 15:46:25 GMT, Artur Barashev <[email protected]> wrote:
>> Roland Mesde has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add Comment on Constructor + Family Behavior and Renamed isInvalid() to >> isInvalidated() > > src/java.base/share/classes/sun/security/ssl/SSLSessionImpl.java line 133: > >> 131: * SSLSessionImpl(SSLSessionImpl, SessionId) joins as session to an >> existing >> 132: * family. Every other constructor starts a new family at >> familyDepth 0. >> 133: */ > > I find this huge comment hard to read. Let's comment each variable separately > instead: > > > // Shared by all members of a family. Sessions whose familyDepth reaches > // this limit are invalid. The limit applies to all branches of the > family. > private final AtomicLong familyDepthLimit; > > // This session's depth in its family, set by a copy constructor. Other > // constructors start a new family at depth 0. > private final long familyDepth; > > // True once this session has produced a copy, even if that copy is later > // garbage collected. On invalidation, familyDepthLimit may be lowered > // only when this flag is true. > private boolean hasDescendant; Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33447#discussion_r4425921680
