On Tue, 20 Oct 2026 22:59:42 GMT, Valerie Peng <[email protected]> wrote:
>> Initial commit containing the public API changes and related regression >> tests. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Valerie Peng has updated the pull request incrementally with one additional > commit since the last revision: > > Updated to address Weijun's review comments. src/java.base/share/classes/com/sun/crypto/provider/Argon2DerivedKey.java line 77: > 75: this.key = key; // internally derived, no need to clone > 76: this.hashCode = Arrays.hashCode(this.key) ^ > 77: algo.toLowerCase(Locale.ENGLISH).hashCode(); Should we normalize `TripleDES` to `desede` to avoid violating the equals()/hashCode() contract? It is normalized in [SecretKeySpec](https://github.com/openjdk/jdk/blob/841e5f8675256921c341dfe92066175166085589/src/java.base/share/classes/javax/crypto/spec/SecretKeySpec.java#L211). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4405371714
