On Wed, 28 Oct 2026 20:30:44 GMT, Artur Barashev <[email protected]> wrote:
>> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated to address Weijun's review comments. > > src/java.base/share/classes/com/sun/crypto/provider/Argon2Impl.java line 411: > >> 409: bl.doFinal(v, 0); >> 410: >> 411: int r = ((outLen + 31) >> 5) - 2; > > I suggest to use `Math.ceilDiv(outLen, 32) - 2` instead to avoid integer > overflow. Yes, good point. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29597#discussion_r4590324807
