On Wed, 21 Oct 2026 09:35:13 GMT, Hai-May Chao <[email protected]> wrote:

>> This feature enables SunJSSE to use a TLS 1.3 hybrid named group implemented 
>> directly by a security provider as JCA `KeyPairGenerator` and `KEM` 
>> services. It also moves the JDK implementations of `X25519MLKEM768`, 
>> SecP256r1MLKEM768, and `SecP384r1MLKEM1024` into SunJCE provider.
>> 
>> ---------
>> - [X] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Hai-May Chao has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Updated with Weijun's comments

Two major comments:
1. I don't understand what those `getXyzProvider` methods in `NamedGroup` are 
for.
2. You can keep the `HybridProvider` class and put `KEM.DH` there, then there 
is no need for those adapter records or classical flags.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33433#issuecomment-6507919637

Reply via email to