On Fri, 30 Oct 2026 08:05:56 GMT, Hai-May Chao <[email protected]> wrote:
>> This feature enables SunJSSE to use a TLS 1.3 hybrid named group implemented >> directly by a security provider as JCA `KeyPairGenerator` and `KEM` >> services. It also moves the JDK implementations of `X25519MLKEM768`, >> SecP256r1MLKEM768, and `SecP384r1MLKEM1024` into SunJCE provider. >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Hai-May Chao has updated the pull request incrementally with one additional > commit since the last revision: > > Remove unused adapter from DHasKEM test/jdk/sun/security/provider/all/Deterministic.java line 214: > 212: g.initialize(new NamedParameterSpec(alg), random); > 213: return g.generateKeyPair(); > 214: } I see why this is necessary, but I would change the hybrid `KeyPairGenerator.initialize(int, rand)` to be identical to `KeyPairGenerator.initialize(params, rand)` so calling it can also set the random. Then there is no need to modify this test. test/jdk/sun/security/provider/all/Deterministic.java line 311: > 309: static String getKeyAlgFromKEM(String algorithm) { > 310: return switch (algorithm) { > 311: case "DHKEM", "DH" -> "X25519"; Is this still needed? "KEM.DH" is not public now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33433#discussion_r4423834432 PR Review Comment: https://git.openjdk.org/jdk/pull/33433#discussion_r4423849778
