On Tue, 3 Nov 2026 16:50:31 GMT, Volodymyr Paprotski <[email protected]> wrote:
>> Larry has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8394260: Address Adler32 AVX2 review comments >> >> Use an unsigned 32-bit type for the division magic constant and update the >> LIMIT overflow comment to refer to the unsigned 32-bit range. >> >> Add an AVX2-specific jtreg run using all-0xFF input around LIMIT. > > src/hotspot/cpu/x86/stubGenerator_x86_64_adler.cpp line 123: > >> 121: const XMMRegister xtmp0 = xmm13; >> 122: const XMMRegister xtmp1 = xmm14; >> 123: const XMMRegister xtmp2 = xmm15; > > guess xtmp3-5 as a place to store registers.. pretty sure move reg<->xmm is > as expensive as push/pop (eg another way to free up some registers from 'do > these overlap anywhere' checks) done; ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4466796838
