On Tue, 3 Nov 2026 17:09:56 GMT, Volodymyr Paprotski <[email protected]> wrote:
>> Larry has updated the pull request incrementally with one additional commit >> since the last revision: >> >> 8394260: Address Adler32 AVX2 review comments >> >> Use an unsigned 32-bit type for the division magic constant and update the >> LIMIT overflow comment to refer to the unsigned 32-bit range. >> >> Add an AVX2-specific jtreg run using all-0xFF input around LIMIT. > > src/hotspot/cpu/x86/stubGenerator_x86_64_adler.cpp line 256: > >> 254: __ movl(rcx, BASE); >> 255: __ divl(rcx); // divide edx:eax by ecx, quot->eax, rem->edx >> 256: __ movl(b_d, rdx); > > not cheaper to use reduce_mod_base on 512 as well?? Since this only changes the AVX-512 path and the current PR is scoped to AVX2, I’ve left it unchanged here. I’ll handle it as part of the follow-up JDK-8396416. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33338#discussion_r4463109403
