> The primary reason for this set of changes is to sanity check the 
> **doubleKeccak** and **quadKeccak** methods. This includes their intrinsified 
> and pure Java variants. The new JTREG source files listed below essentially 
> validate return values from invoked private methods using the Java Reflection 
> API.
> 
> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java`
> 2. 
> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java`
> 3. 
> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java`
> 
> Additionally, the multi block intrinsic tests now check the correct 
> **implCompressMultiBlock0** method. All modifications and tests used [OpenJDK 
> v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) as the 
> baseline build.
> 
> ---------
> - [x] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

Mohamed Issa has updated the pull request incrementally with three additional 
commits since the last revision:

 - Remove check for _quad_keccak stub as that change should be done in separate 
PR.
 - Use AND predicates in multi-block intrinsic tests in case a VM setting makes 
stubs silently unavailable.
 - Remove and block tiered compilation from SHA3 parallel tests as that 
conflicts with compile threshold setting.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/33709/files
  - new: https://git.openjdk.org/jdk/pull/33709/files/b5696925..4ce300de

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=33709&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=33709&range=05-06

  Stats: 43 lines in 7 files changed: 22 ins; 3 del; 18 mod
  Patch: https://git.openjdk.org/jdk/pull/33709.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/33709/head:pull/33709

PR: https://git.openjdk.org/jdk/pull/33709

Reply via email to