On Tue, 10 Nov 2026 21:36:55 GMT, Mohamed Issa <[email protected]> wrote:
>> The primary reason for this set of changes is to sanity check the >> **doubleKeccak** and **quadKeccak** methods. This includes their >> intrinsified and pure Java variants. The new JTREG source files listed below >> essentially validate return values from invoked private methods using the >> Java Reflection API. >> >> 1. `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java` >> 2. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java` >> 3. >> `jtreg:test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA3ParallelIntrinsics.java` >> >> Additionally, the multi block intrinsic tests now check the correct >> **implCompressMultiBlock0** method. All modifications and tests used >> [OpenJDK v28-b22](https://github.com/openjdk/jdk/releases/tag/jdk-28%2B22) >> as the baseline build. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Mohamed Issa has updated the pull request incrementally with three additional > commits since the last revision: > > - Remove check for _quad_keccak stub as that change should be done in > separate PR. > - Use AND predicates in multi-block intrinsic tests in case a VM setting > makes stubs silently unavailable. > - Remove and block tiered compilation from SHA3 parallel tests as that > conflicts with compile threshold setting. test/hotspot/jtreg/compiler/intrinsics/sha/TestInvoke.java line 45: > 43: import java.lang.reflect.Method; > 44: > 45: public class TestInvoke { Since this is specific to SHA3Parallel the class name should reflect that, e.g. TestSHA3Parallel. test/hotspot/jtreg/compiler/intrinsics/sha/sanity/InvokeSanityTestBase.java line 39: > 37: * Base class for sanity tests on SHA intrinsic invocations. > 38: */ > 39: public class InvokeSanityTestBase { Since this is specific to SHA3Parallel the class name should reflect that, e.g. SHA3ParallelTestBase. test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA1Intrinsics.java line 41: > 39: * -XX:CompileOnly=sun.security.provider.DigestBase::* > 40: * -XX:CompileOnly=sun.security.provider.SHA::* > 41: * -XX:+UseSHA1Intrinsics -Dalgorithm=SHA-1 I don't think that this file should be changing. test/hotspot/jtreg/compiler/intrinsics/sha/sanity/TestSHA256Intrinsics.java line 41: > 39: * -XX:CompileOnly=sun.security.provider.DigestBase::* > 40: * -XX:CompileOnly=sun.security.provider.SHA2::* > 41: * -XX:+UseSHA256Intrinsics -Dalgorithm=SHA-224 I don't think that this file should be changing. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4535673044 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4535671644 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4535669871 PR Review Comment: https://git.openjdk.org/jdk/pull/33709#discussion_r4535664183
