Roland Mainz wrote: > Casper.Dik at Sun.COM wrote: >>> Tony Nguyen wrote: >>>> The updated and incremental webrevs are at: >>>> >>>> http://cr.opensolaris.org/~tonyn/firewall29Oct2008/ >>>> >>>> http://cr.opensolaris.org/~tonyn/firewall-inc/ >>>> >>>> The original webrev is still available at: >>>> >>>> http://cr.opensolaris.org/~tonyn/firewall/ >>> Before starting to comment on the scripts: Is it mandatory for the >>> firewall SMF scripts to use /sbin/sh or is /usr/bin/ksh acceptable, too >>> ? >> Possibly if you make sure that /usr is mounted first. > > The scripts already use stuff like "sed" ([1]) and AFAIK that means they > depend on /usr being mounted. > > [1]=my main concern is that this script could be slighty reworked to > avoid depending on "sed"&co. just to dismantle one single string - > builtin shell operators can do the same in a much faster manner (and if > we're allowed to use ksh93 we may be able to fold various calls to > "svcprop" to just one in a similar manner how > http://svn.genunix.org/repos/on/branches/ksh93/gisburn/scripts/svcproptree1.sh > works). >
Hi Roland, It's a good point. network/ipfilter has a dependency on filesystem/usr so that isn't an issue. If we use ksh, it'd have to be ksh93 since that's the only version shipped with OpenSolaris. However, making this script ksh93 requires method scripts delivered by other teams and consolidations to be ksh93 which I'm not ready to mandate and perhaps requiring ARC commitment. I'd like to defer the suggested change until the follow up IPv6 support work at which I can make that proposal. Thanks, tony
