Location: inetd.c 302-327 Type: T Priority: 1 Comment: first, will scf_instance_destroy(NULL) crash inetd? The man page doesn't explicitly state this is ok, so one would assume not. Additionally. rather than do line 321, put this at 312 and make 320 just be "if (ret != 0)".
Location: inetd.c 336-347 Type: T Priority: 2 Comment: Restructuring this function to eliminate the goto appears easily possible, although it will require the use of "else". Location: inetd.c 369-381 Type: T Priority: 2 Comment: same as for lines 336-347. Location: ipfd.c 407 Type: T Priority: 3 Comment: Line is redundant with 401. Location: ipfd.c 508-533 Type: T Priority: 2 Comment: Rather than do "if()-else", consider just putting one of the conditions with the if() and have the other being the default so that the lint hint at 533 can be removed. Location: ipfd.c 539 Type: T Priority: 2 Comment: boolean_t's should be initialised with either B_FALSE or B_TRUE, not an integer.
