Hi!
After upgrading to 1.12 I've found that problem with format=embedded and
further results link didn't disappear (no wonder).
So, I've looked through the code and found a simple fix. It seems that
searchlabel was applied not checking it's empty value,
which _should_ means that further results link will be suppressed.
This behaviour contradicts with older SMW versions. Also, format=list
has such check. Also, my template uses
two #ask queries with embedded format, so further link may appear in the
middle of resulting output. That's bad.
I hope my fix can be integrated into SVN. If something is wrong with it,
please let me know.
Sincerely,
Dmitriy
Index: /vol3/SMW/SemanticMediaWiki-35785-fix/includes/SMW_QP_Embedded.php
===================================================================
--- /vol3/SMW/SemanticMediaWiki-35785-fix/includes/SMW_QP_Embedded.php
(.../http://svn.wikimedia.org/svnroot/mediawiki/trunk/extensions/SemanticMediaWiki)
(revision 35785)
+++ /vol3/SMW/SemanticMediaWiki-35785-fix/includes/SMW_QP_Embedded.php
(.../vol3/SMW/SemanticMediaWiki-35785-fix) (working copy)
@@ -107,7 +107,7 @@
}
// show link to more results
- if ( $this->mInline && $res->hasFurtherResults() ) {
+ if ( $this->mInline && $res->hasFurtherResults() &&
$this->mSearchlabel !== '') {
$link = $res->getQueryLink();
if ($this->mSearchlabel) {
$link->setCaption($this->mSearchlabel);
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
