CNIT wrote:
> After upgrading to 1.12 I've found that problem with format=embedded 
> and further results link didn't disappear (no wonder).
> So, I've looked through the code and found a simple fix. It seems that 
> searchlabel was applied not checking it's empty value,
> which _should_ means that further results link will be suppressed.
> This behaviour contradicts with older SMW versions. Also, format=list 
> has such check.

I reproduced 
<http://sandbox.semantic-mediawiki.org/wiki/SMW_unit_test:Test_inline_query_embedding>,
 
and filed bug 14330.  Your fix looks right and matches 
SMW_QP_{List,Table,Template}.php.
Thanks for the report, you could have created the test case and filed a 
bug yourself.

> When I set searchlabel=Label1, it displays link with title Label1 twice -
> once as a last row of embedded list, second time as a proper searchlabel 
> link.

I couldn't reproduce that problem on SMW 1.2 pre-releases.  I just get 
searchlabel once as the last row of the embedded list.

--
=S Page

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel

Reply via email to