Hi Jeroen, The proposed change is rather minimal, it only changes the Html definition in SMWQuerySpecialPage and adds some js function to ext.smw.ask. Finished !
I'd looked at Special:QueryCreator but I had to turn my back because my experience is not a match for what goes on in the QueryCreator UI class and while your are probably right that Special:Ask has its problems it appears still being more adoptable than QueryCreator (at least I was able to find my way around in Special:Ask). For example class SMWAskPage has 614 lines of code but class SMWQueryUI alone has 1818 ( + class SMWQueryCreatorPage 264 + class SMWQueryUIHelper 589). The main reason for the proposal was to get something done now with the least effort until Special:QueryCreator gets fixed and becomes superior to Special:Ask. Cheers, mwjames On 7/22/12, Jeroen De Dauw <jeroended...@gmail.com> wrote: > Hey, > > That definitely looks better the the current UI. However before starting to > make such changes, I think we should asses how much effort it would be to > get the query UI written by Devayon Das as part of GSoC 2011 finished up > and have that replace ask. > > It can be seen working here: > http://semantic-mediawiki.org/wiki/Special:QueryCreator > > The code is in special/AskSpecial/SMW_SpecialQueryCreator, SMW_QueryUI and > SMW_QueryUIHelper. > > I'd much prefer this over continuing work on Special:Ask, as the code has > really become a mess over the years, and there is a lot of stuff there that > should be in separate components, so they can be maintained loose from Ask, > and also be used by other query UIs. I'm not sure this new code is much > better then ask in that regard (as I'm not familiar with it), but it's > probably already a step in the right direction. Markus can probably comment > on this in greater detail. > >> Jeroen, I don't not why but getStrInput (class ParameterInput ) sets the > input field size to 32 > > At some point I abstracted out the input generation code and made it a bit > more generic. However, there is still a lot of work to be done there. We > can have much smarter inputs now all the parameter definition information > is available :) > > -- > Jeroen De Dauw > http://www.bn2vs.com > Don't panic. Don't be evil. > -- > ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Semediawiki-devel mailing list Semediawiki-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/semediawiki-devel
