o Raúl Alexis Betancor Santana [10/07/09 12:57]:
On Miércoles, 7 de Octubre de 2009 11:31:59 Stefan Sayer escribió:
Hello Raul,

o Raúl Alexis Betancor Santana [09/25/09 16:32]:
I need that feature implemented, so I'll be working on it during this
weekend, so if someone have been working on it and have some patches or
something developed and could send it to me to get it improved or
completed, I'll be very happy to receive them.

Best regards
this is added in r1505.

You need to specify the variables you use in voicemail.conf which is a
little inflexible, but to change the email template I think you need to
restart the server anyway (which is in fact not very good.). I made it
this way because I wanted to use get_header_keyvalue function which
supports quoting and escaping.


I'll improve this, because I prefer that extra variables get passed to the template without having to touch the .conf.

Maybe throught the mysql table that handle templates ... I'll check you patch and see how to improve it.

Thanks for your efforts.

ok. I think the first thing to do then is to reload the email templates while SEMS is running. you could do this by simply calling onLoad from a DI function, only that you need to take care that you don't create any new voicemail calls while onLoad happens (might crash otherwise if something is accessed at the same time). You could for example simply use an AmMutex around onLoad and AnswerMachineFactory::onInvite (no performance impact here, because Factory::onInvite is called by one thread only).

Another solution is to load the email template when the call comes in. I don't know whether email templates change so often that this is really needed. It is needed if you want to give your users the possibility to individually change how their voicemail looks, but i really don't know if anyone would need that (except maybe selecting between some choices, which you could implement with domains anyway).

Stefan

--
Stefan Sayer
VoIP Services

[email protected]
www.iptego.com

IPTEGO GmbH
Wittenbergplatz 1
10789 Berlin
Germany

Amtsgericht Charlottenburg, HRB 101010
Geschaeftsfuehrer: Alexander Hoffmann
_______________________________________________
Sems mailing list
[email protected]
http://lists.iptel.org/mailman/listinfo/sems

Reply via email to