Hi Jeremy,
Thanks for providing the patch as a separate file. This actually made
it possible for me to patch on the home computer using GNUWIN32 patch.
We don't use patch files at work so I'm just getting used to them. :)
At any rate, I did find a bug when trying to run this:
db = Sequel.connect( "mysql://root:[EMAIL PROTECTED]/test" )
db.create_table :double__underscores.identifier do
varchar :name
end
db.drop_table :double__underscores.identifier
So this was run against my test database. It successfully creates
the :double__underscores table but it doesn't successfully drop the
table.
Here are the Sequel error messages:
undefined method `remove_cached_schema' for #<Sequel::MySQL::Database:
"mysql://root:[EMAIL PROTECTED]/test"> - NoMethodError
c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/
schema.rb, line: 112, method: drop_table »
c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/
schema.rb, line: 111, method: each »
c:/ruby/lib/ruby/gems/1.8/gems/sequel-2.7.1/lib/sequel_core/database/
schema.rb, line: 111, method: drop_table »
Sunny
On Nov 15, 10:08 pm, Jeremy Evans <[EMAIL PROTECTED]> wrote:
> On Nov 15, 8:27 pm, Jeremy Evans <[EMAIL PROTECTED]> wrote:
>
>
>
> > On Nov 15, 2:53 pm, Sunny Hirai <[EMAIL PROTECTED]> wrote:
>
> > > Just wanted to apologize for the ongoing lateness. My computer at home
> > > is half dead but I've been doing everything I can to get the patches
> > > applied. Unfortunately, Eclipse and Aptana have bit the dust and they
> > > had a nice feature to do it. Reinstalling doesn't work. I tried used
> > > GNUWIN32 patch but it doesn't seem to be working either. I was working
> > > on some manual fixing, then PSPad bit it too. This computer can't seem
> > > to do much more than browse the web and lock up. I've already ordered
> > > a replacement for it last week.
>
> > > Should have done it at work but there was a lot going on this week and
> > > I missed doing it. Sorry. I will make sure to get it checked on Monday
> > > at work computer.
>
> > I feel your pain, Sunny, I've been having problems with my workstation
> > as well. I've been working on a way to handle the changes to
> > @schemas, it's not complete yet. When I have something working, I'll
> > probably post here or just commit it.
>
> Here's a patch that contains all the changes mentioned so far in this
> thread:
>
> http://code.jeremyevans.net/sequel_schema.diff
>
> It's quite large, which is the reason I didn't inline it. What's new
> is better support for the new key format for @schemas, so dropping
> tables removes them from the @schemas, as well as some changes to
> PostgreSQL's schema parser (the only one that handles getting the
> schema for all tables at once). I decided to retain backwards
> compatibility to the extent possible. So the keys are quoted strings
> instead of symbols, but using a symbol will still get you the same
> info. It also contains the necessary spec changes. Also, it changes
> table_exists? to check the schema info, and report true if the table
> is in the schema. If it isn't in the schema or there is no schema
> information, it does a query.
>
> Please test this patch with your app(s) and see if there are any
> remaining schema/identifier issues. I have only run this through one
> of my test suites (which it passed). I'll run it through my other
> test suite on Monday, and probably commit it then if it passes, unless
> I hear from you. I want to get this patch in before I work on some of
> the other issues that have been added to the bugtracker recently.
>
> Jeremy
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sequel-talk" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/sequel-talk?hl=en
-~----------~----~----~----~------~----~------~--~---
