On Dec 3, 2009, at 10:15 AM, Jeremy Evans wrote: > On Dec 3, 6:49 am, Chuck Remes <[email protected]> wrote: >> On Dec 2, 2009, at 2:32 PM, Jeremy Evans wrote: >>> If you fix those issues and add documentation and specs, I'll >>> include >>> this as long as it passes the test suite. >> >> I just forked the repository. I'll send you a pull request after I >> get >> this implemented and documented. > > Great! Thanks for your help.
You're welcome. You (and Sharon before you) already did most of the hard stuff! >> I would suggest adding this behavior as optional parameters to >> Database#disconnect. >> >> :remove_all => boolean >> Flag all connections to be disconnected and removed from the pool >> >> :async => boolean >> When true, perform this operation asynchronously. When false, block >> until all connections are removed. > > I'd change this option to :sync. Async is the current behavior, if > you want synchronous behavior, you should need to specify it. Unless > you think synchronous behavior is the better default and worth > breaking backwards compatibility for. I agree with the change to :sync so it defaults to async. > Lots of good ideas here, I'm sure we can get this done this month in > time for Sequel 3.8.0. I'm sending you a pull request now for the #add_servers functionality. I'd appreciate feedback on the documentation. cr -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
