On Dec 3, 8:15 am, Jeremy Evans <[email protected]> wrote: > On Dec 3, 6:49 am, Chuck Remes <[email protected]> wrote: > > I would suggest adding this behavior as optional parameters to > > Database#disconnect. > > > :remove_all => boolean > > Flag all connections to be disconnected and removed from the pool > > > :async => boolean > > When true, perform this operation asynchronously. When false, block > > until all connections are removed. > > I'd change this option to :sync. Async is the current behavior, if > you want synchronous behavior, you should need to specify it. Unless > you think synchronous behavior is the better default and worth > breaking backwards compatibility for. > > Lots of good ideas here, I'm sure we can get this done this month in > time for Sequel 3.8.0.
Here's a partial patch that implements some of what we discussed: http://pastie.org/731352.txt No documentation or additional specs yet, but it does pass the existing specs. It's missing the :sync option, but it makes :remove_all the default (with no option to just disconnect available connections), since I think that is the most sensible approach. Not in committable form yet, but I'm putting it out there early to get some feedback. So please respond and let me know what you think. Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
