Em 26-10-2012 18:00, Jeremy Evans escreveu:
On Friday, October 26, 2012 12:42:37 PM UTC-7, Jeremy Evans wrote:

    On Friday, October 26, 2012 12:16:02 PM UTC-7, Rodrigo Rosenfeld
    Rosas wrote:

        Just to let you know, it seems a Monitor is reentrant if you
        want to take this path:

        http://japgolly.blogspot.com.br/2012/04/ruby-mutex-reentrancy.html
        <http://japgolly.blogspot.com.br/2012/04/ruby-mutex-reentrancy.html>


    I'm aware of the difference, Mutex is being used on purpose for
    performance (Monitor is about 2.5x slower).

    One other limitation with the current code is that it does the
    connection validation while holding the pool mutex, which means
    that no other threads can checkout a connection while this
    connection is being validated.  That's very bad.  I've modified
    things so the checking is done while not holding the mutex (in
    addition to precaching the SQL).

    I'm just running the changes through a final set of tests,
    hopefully it will be pushed within 15 minutes.


I just pushed the fix: https://github.com/jeremyevans/sequel/commit/40bcfcb9ff5b39c882c204792f1095e95300721f

Please test and let me know whether it works for you.  Thanks for testing!

I'll do it right now, thanks!

--
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.

Reply via email to