On Monday, December 31, 2012 11:33:43 AM UTC-8, rohit wrote:
>
> Hi Jeremy,
>
> Any objections to adding this to Sequel
>
> module Sequel
>   class Dataset
>     def group_more(*columns, &block)
>       cols = @opts[:group]
>       group(*(cols + columns), &block)
>     end
>   end
> end
>
>
Every method added to core Sequel is an additional memory cost that all 
applications must pay.  My objection to adding this method is that usage 
does not appear common enough to make the memory cost to all applications 
worth the marginal benefit to the rare applications that would benefit from 
it, considering the ease of adding the method via monkey-patching.

That being said, I'm not opposed to adding the method to core Sequel if 
some other users express interest.  Maybe usage of this method is more 
common than I expect.

Thanks,
Jeremy

-- 
You received this message because you are subscribed to the Google Groups 
"sequel-talk" group.
To view this discussion on the web visit 
https://groups.google.com/d/msg/sequel-talk/-/2OIITxw3FTgJ.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sequel-talk?hl=en.

Reply via email to