+1 on adding this. I've built web apps now with Sequel now and like to build reporting systems in for the delivered solution whereby I often build a core dataset in base reporting classes, then extend the dataset with additional joins and groupings, etc. in descendent classes. This one particularly would allow me to streamline the "builder" code chain and probably should've thought to monkey patch like this myself. having_more would be another one I'd like to have.
Is there perhaps a way to add these additional features in extension/plugins and we can optionally load? I have to imagine Sequel's core has become pretty feature complete and most new additions and requests are starting to be like this one and are syntactic sugars Regards, Michael On Tue, Jan 1, 2013 at 5:09 PM, Jeremy Evans <[email protected]> wrote: > On Monday, December 31, 2012 11:33:43 AM UTC-8, rohit wrote: >> >> Hi Jeremy, >> >> Any objections to adding this to Sequel >> >> module Sequel >> class Dataset >> def group_more(*columns, &block) >> cols = @opts[:group] >> group(*(cols + columns), &block) >> end >> end >> end > > > Every method added to core Sequel is an additional memory cost that all > applications must pay. My objection to adding this method is that usage > does not appear common enough to make the memory cost to all applications > worth the marginal benefit to the rare applications that would benefit from > it, considering the ease of adding the method via monkey-patching. > > That being said, I'm not opposed to adding the method to core Sequel if some > other users express interest. Maybe usage of this method is more common > than I expect. > > Thanks, > Jeremy > > -- > You received this message because you are subscribed to the Google Groups > "sequel-talk" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/sequel-talk/-/2OIITxw3FTgJ. > > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/sequel-talk?hl=en. -- http://codeconnoisseur.org -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/sequel-talk?hl=en.
