On Oct 10, 2013, at 3:05 PM, Jeremy Evans <[email protected]> wrote:
> On Thursday, October 10, 2013 10:10:20 AM UTC-7, GregD wrote: > > On Oct 3, 2013, at 10:08 PM, Jeremy Evans <[email protected]> wrote: > > > > > If you have a GitHub account, just pushing your branch up to your fork on > > GitHub should be enough. Alternative, hosting your git repo anywhere I can > > access it should be fine. Worse cast scenario, providing the output of git > > diff against my master branch should be enough. > > gditrick is my github account. I forked your sequel. I created 2 branches: > sqlanywhere and jdbc_smallint_to_bool. The sqlanywhere branch is for the > native with smallint_to_bool and jdbc without it. The jdbc branch will allow > the jdbc to act the same as the native when dealing with smallint_to_bool > which can be overridden for a database or a dataset and defaults to true. > This gets the base integration tests down to the very minimal pending: 2 for > jdbc and 3 for native. If that is not desirable, I say we remove the > smallint_to_bool completely for both to keep them consistent. We are only > talking about 3 more tests that would go to pending for sqlanywhere, since > it does not have a boolean datatype. > > > > > I still need to get a local VM with sqlanywhere setup. I filled out the > > online form on Sybase's website, but they never sent a key for me to > > download the developer version. > > For what it is worth, I created a gist for helping with this. It was hard to > remember what exactly I did setting up sqlanywhere on my ubuntu VM. > > https://gist.github.com/gditrick/689069 > > From my brief review, this looks good. It might take me a little while to > get it fully reviewed and merged, but it will definitely happen before the > next release. Thank you very much for your work on this. No problem. Enjoy Ruby a lot. :) And I wish I was doing it full time! Regards, -GregD -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/groups/opt_out.
