On Thursday, April 9, 2015 at 4:08:40 AM UTC-7, Jurgens du Toit wrote: > > Hey > > We recently switching from using the mssql adapter to using the odbc > adapter. It seems, though, that the ODBC adapter doesn't convert MSSQL bit > fields into booleans, causing some eratic behaviour in our apps. > > I tried looking through the code for a setting or where this was > previously solved, but couldn't find any. I ended up doing a small code > change, but couldn't find the proper place to test it. > > Can I get some feedback / input on this? The proposed PR is here: > https://github.com/jeremyevans/sequel/compare/master...jrgns:odbc-bit-is-boolean >
Just looking at the diff, it appears this may negatively affect the conversion of timestamp, time, and date objects. Have you run the tests (rake spec_mssql) both with and without this diff to see what the effect is? I'm OK with the idea of handling bit types in the ODBC adapter, as long as it doesn't break anything. Could you mention why you switched adapter? In general the tinytds adapter is better supported, and I would recommend using it over the odbc adapter. Thanks, Jeremy -- You received this message because you are subscribed to the Google Groups "sequel-talk" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/sequel-talk. For more options, visit https://groups.google.com/d/optout.
